Fix #77 approve bitbucket PRs when configured. #541
Conversation
This feature requires a write access configured in OAuth consumers. Add a new configuration parameter under ALMSettings/Bitbucket to enable or not this behavior (default false). When enabled and sonar analysis a pull request branch the logged user will approve/disapprove current PR based on quality gate result.
|
You can't add options on the MR/PR configuration screens given the way they're built. I'm also not a fan of adding configuration on other screens as it makes it difficult for users to find all the configuration options they're supposed to set. Is approvals something that Sonarqube offers in its commercial offerings? |
|
Do you prefer a dedicated page? But this page should refer only to bitbucket action
No at least from documentation and also because their setup does not describe Write right for PullRequest on Oauth consumers, this means it can not perform aprrove action like this |
|
I did there because is strctly resrticted to bitbucket ALM integration behavior. I see you removed a lot of custom properties relying on branch default. Actually there is only one in general settings (category). |
|
Closed in favor of this plugin https://github.com/nfalco79/sonar-bitbucket-cloud to approve PullRequests |
This feature requires a write access configured in OAuth consumers.
Add a new configuration parameter under ALMSettings/Bitbucket to enable or not this behavior (default false). When enabled and sonar analysis a pull request branch the logged user will approve/disapprove current PR based on quality gate result.
Before spend time to implement test case please let me know if you are yet interested on this (#77) feature
In picture seems I can not change how "bitbucket" sub category appears, adding a description for example. It looks like something that depends on sonarqube server.